-
Notifications
You must be signed in to change notification settings - Fork 109
chore: upgrade db packages #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the dependency configuration in the Changes
Possibly related PRs
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 3034c97 | Previous: 9aa404b | Ratio |
|---|---|---|---|
BenchmarkFile_ReadWrite |
320995 ns/op 2072 B/op 27 allocs/op |
181949 ns/op 2072 B/op 27 allocs/op |
1.76 |
BenchmarkFile_ReadWrite - ns/op |
320995 ns/op |
181949 ns/op |
1.76 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #848 +/- ##
=======================================
Coverage 67.16% 67.16%
=======================================
Files 150 150
Lines 10442 10442
=======================================
Hits 7013 7013
Misses 3055 3055
Partials 374 374 ☔ View full report in Codecov by Sentry. |
|
framework/database/console/show_command.go Line 108 in 9aa404b
Unrelated to this PR, but just a quick note: the database names should follow their proper casing and full names—PostgreSQL, MySQL, MariaDB, SQL Server, and SQLite—instead of lowercase driver name like postgres, mysql, sqlite, or sqlserver. |
@almas1992 Good catch, for |
I think adding a new method to retrieve the DB name works(Laravel has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
|
@almas1992 Could you create an issue to trace this? |
Okay |
📑 Description
goravel/goravel#540
Summary by CodeRabbit