Skip to content

chore: optimize error handling #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almas-x merged 1 commit into from
Feb 18, 2025
Merged

chore: optimize error handling #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ import (
"prefix": "",
"schema": "",
"via": func() (driver.Driver, error) {
return postgresfacades.Postgres("postgres"), nil
return postgresfacades.Postgres("postgres")
},
// Optional
"read": []contracts.Config{
Expand Down
12 changes: 5 additions & 7 deletions facades/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,24 @@
package facades

import (
"log"
"fmt"

"github.com/goravel/framework/contracts/database/driver"

"github.com/goravel/postgres"
)

func Postgres(connection string) driver.Driver {
func Postgres(connection string) (driver.Driver, error) {
if postgres.App == nil {
log.Fatalln("please register postgres service provider")
return nil
return nil, fmt.Errorf("please register postgres service provider")
}

instance, err := postgres.App.MakeWith(postgres.Binding, map[string]any{
"connection": connection,
})
if err != nil {
log.Fatalln(err)
return nil
return nil, err
}

return instance.(*postgres.Postgres)
return instance.(*postgres.Postgres), nil
}