Skip to content

Commit 06eeaa2

Browse files
committed
[mv3] Add topDomains/excludedTopDomains conditions to DNR parser
1 parent 33dc8a7 commit 06eeaa2

3 files changed

Lines changed: 16 additions & 0 deletions

File tree

platform/mv3/extension/js/dnr-parser.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,8 @@ const perScopeParsers = {
280280
case 'excludedInitiatorDomains':
281281
case 'requestDomains':
282282
case 'excludedRequestDomains':
283+
case 'topDomains':
284+
case 'excludedTopDomains':
283285
case 'resourceTypes':
284286
case 'excludedResourceTypes':
285287
case 'requestMethods':
@@ -328,6 +330,16 @@ const perScopeParsers = {
328330
rule.condition.excludedRequestDomains.push(node.val);
329331
return true;
330332
},
333+
'condition.topDomains': function(scope, rule, node) {
334+
if ( node.list !== true ) { return false; }
335+
rule.condition.topDomains.push(node.val);
336+
return true;
337+
},
338+
'condition.excludedTopDomains': function(scope, rule, node) {
339+
if ( node.list !== true ) { return false; }
340+
rule.condition.excludedTopDomains.push(node.val);
341+
return true;
342+
},
331343
'condition.resourceTypes': function(scope, rule, node) {
332344
if ( node.list !== true ) { return false; }
333345
if ( validResourceTypeValues.includes(node.val) === false ) { return false; }

platform/mv3/extension/js/rw-dnr-editor.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,8 @@ export class ReadWriteDNREditor extends DNREditor {
194194
{ token: 'excludedInitiatorDomains:', after: '\n - ' },
195195
{ token: 'requestDomains:', after: '\n - ' },
196196
{ token: 'excludedRequestDomains:', after: '\n - ' },
197+
{ token: 'topDomains:', after: '\n - ' },
198+
{ token: 'excludedTopDomains:', after: '\n - ' },
197199
{ token: 'resourceTypes:', after: '\n - ' },
198200
{ token: 'excludedResourceTypes:', after: '\n - ' },
199201
{ token: 'requestMethods:', after: '\n - ' },

platform/mv3/extension/js/ubo-parser.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,8 @@ function minimizeRuleset(rules) {
162162
rules = mergeArrays(rules, 'condition.excludedRequestDomains');
163163
rules = mergeArrays(rules, 'condition.initiatorDomains');
164164
rules = mergeArrays(rules, 'condition.excludedInitiatorDomains');
165+
rules = mergeArrays(rules, 'condition.topDomains');
166+
rules = mergeArrays(rules, 'condition.excludedTopDomains');
165167
rules = mergeArrays(rules, 'condition.resourceTypes');
166168
rules = mergeArrays(rules, 'condition.excludedRequestMethods');
167169
rules = mergeArrays(rules, 'condition.requestMethods');

0 commit comments

Comments
 (0)