Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please clarify uBlock₀ vs. uBlock #38

Closed
rusvnc opened this Issue Apr 11, 2015 · 21 comments

Comments

Projects
None yet
@rusvnc
Copy link

rusvnc commented Apr 11, 2015

This is confusing. Are you recommending users with the present extension (i.e. uBlock₀) should now install uBlock from the new repository? If so this should be stated clearly somewhere.

@SW1FT

This comment has been minimized.

Copy link
Contributor

SW1FT commented Apr 11, 2015

There's nothing to clarify here. If you like Gorhill's version stick with it, if not, go for Chris Aljoudi's.

@rusvnc

This comment has been minimized.

Copy link
Author

rusvnc commented Apr 11, 2015

I beg to differ. For one thing, if this is going to be actively maintained, it is unclear why gorhill transferred the official repository to chrisaljoudi, rather than chrisaljoudi starting a fork of the extension. Given that gorhill has previously deprecated extensions in favour of new extensions, some explanation would be useful.

@gorhill

This comment has been minimized.

Copy link
Owner

gorhill commented Apr 11, 2015

Dup of #12.

@gorhill gorhill closed this Apr 11, 2015

@Betsy25

This comment has been minimized.

Copy link

Betsy25 commented Apr 11, 2015

@rusvnc There are only 3 simple rules about this :

  • Always backup up your settings before switching between the forks.
  • Never run both forks simultaneously.
  • You have the total freedom to choose whichever fork you like.
@gorhill

This comment has been minimized.

Copy link
Owner

gorhill commented Apr 11, 2015

unclear why gorhill transferred the official repository to chrisaljoudi

These projects are hobby to me, not full time job. It stopped being a hobby when it felt more and more like a tedious job. I will keep maintaining my version (and share with whoever care to use it) because it guarantees the tool will match what I want out of it.


Addendum: Since I am going to use this entry as my official response to this recurring question, I will add.

In case you wonder why it felt tedious: go to Adblock Plus forum, and notice how the moderators are quite busy answering to all kind of never ending requests (including nonsensical ones sometimes). It's a full time job, and not a fun one as far as I am concerned. And especially not dealt with by ABP developers.

This is how however more and more of my time was spent, and no doubt it would just become worst as uBlock gained popularity. So I was getting sucked into something I never intended to do.

A hobby is something you enjoy, not something which feels like a tedious job. I am back to how I want it to be. There is nothing more to say about this or justify to anyone how I choose to spend my time[1].

[1] I unfortunately have to spell this last one out because of the unsolicited "advices" I received from random internet people -- who never contributed to the project -- about what I should have done instead.

@ghost

This comment has been minimized.

Copy link

ghost commented Apr 11, 2015

Hello, I understand but why gave up uBlock one day and less tehan one week later, came back to make a fork ? Why don't work with the "official" uBlock" team (it seems they need some help) ? Your last release works very well, congratulations and sorry for my bad english, I'm French.

Alain

Date: Sat, 11 Apr 2015 09:02:54 -0700
From: notifications@github.com
To: uBlock@noreply.github.com
Subject: Re: [uBlock] Please clarify uBlock₀ vs. uBlock (#38)

unclear why gorhill transferred the official repository to chrisaljoudi

These projects are hobby to me, not full time job. It stopped being a hobby when it felt more and more like a tedious job. I will keep maintaining my version (and share with whoever care to use it) because it guarantees the tool will match what I want out of it.


Reply to this email directly or view it on GitHub.

@justinshepard

This comment has been minimized.

Copy link

justinshepard commented Apr 19, 2015

@ghost: By handing over the official repository, he ensures that the "official uBlock" is maintained by a team that is willing/able to handle the "tedious job" aspects of having a popular, useful addon. gorhill maintaining his own fork allows him to actually enjoy working on uBlock without getting burned out and discouraged. It also means he is free to innovate without breaking things or pissing off a bunch of people that may not like a particular feature. This is a win/win/win for all parties involved.

@dolohow

This comment has been minimized.

Copy link

dolohow commented Apr 19, 2015

@gorhill If I were you I would just ignore all the created issues and pull requests or even disable the ability of creating the new ones. If someone wants to change the direction of the project then there is always a possibility of creating a new fork as GPLv3 allowing to do that.

@gorhill

This comment has been minimized.

Copy link
Owner

gorhill commented Apr 19, 2015

@dolohow The project would suffer if people can not file bug reports, uBlock wouldn't be what it is now without the bug reports.

For the feature requests, I have no problem closing them if I want to, at least now it is spelled out in here, so I can use this as reference without further comment if I want to. I keep some feature requests open though because many of them are things I thought about in the past, so I may or may not decide to do something about them.

@PeteSebeck

This comment has been minimized.

Copy link

PeteSebeck commented Apr 20, 2015

Enjoy your hobby and enjoy life. Its way to short. Just wanted to stop by and say thank you for this great project and taking the initiative. My browsing experience is better for it :) I'll use the new fork of your product and keep track of your work for future innovations.

@ticoombs

This comment has been minimized.

Copy link

ticoombs commented Apr 21, 2015

have a coffee for your hard work on me @gorhill @changetip

@changetip

This comment has been minimized.

Copy link

changetip commented Apr 21, 2015

Hi @gorhill, @ticoombs sent you a Bitcoin tip worth a coffee (6,642 bits/$1.50), and I'm here to deliver it ➔ collect your tip.

Learn more about ChangeTip

@EamonNerbonne

This comment has been minimized.

Copy link

EamonNerbonne commented Apr 27, 2015

By releasing ublock-origin so soon (and naming it so prominently to be the "original" version), you're stealing some of your own transition's thunder. There's a risk users will install your more trusted version, and that the new owner will lose motivation. Good luck with future development, in any case!

@gorhill

This comment has been minimized.

Copy link
Owner

gorhill commented Apr 27, 2015

@EamonNerbonne

Main reason I published on AMO is because a feature which I think is important was removed from uBlock (per-site switches). That both versions diverged significantly enough so soon is not in my control.

When ABP added "acceptable ads" in their fork, they also created a demand for a version uncompromised by the "acceptable ads" principle, hence ABE happened. When uBlock removed the
per-site switches, a demand was created for a version of uBlock with the per-site switches.

This is the reality of GPL: anybody can fork and create their own flavor if they disagree with the pre-fork version. This should not be seen as wrong when it happens, it's expected. In the big picture, users win.

As far as trust is concerned, both versions can be trusted -- that should not be an issue in either case: the development and source code is public in both cases (every single code change can be easily browsed on github).

Edit: Notice that I still contribute fixes to uBlock since the fork, and also try to deal with filed issues (those issues which are relevant to both versions), so it's not like I am ignoring uBlock to the advantage of uBlock Origin -- I also want uBlock to work fine for whoever uses it, I just strongly disagree with the removal of the per-site switches feature.

Edit (2015-06-15): Somewhere toward the end of May, I decided I will not contribute code anymore to https://github.com/chrisaljoudi/uBlock anymore. See top of README.

@chrcoluk

This comment has been minimized.

Copy link

chrcoluk commented Jun 3, 2015

This i feel needs more publicity, my head is a in a twist wondering whats going on and which ublock to use.

Basically if I understand you right, ublock got too big, and you got sick of all the support requests, so you forked it off, knowing that ublock will get the vast majority of users and hence the vast majority of support requests whilst your own fork is a much smaller userbase and hence less pressure.

The issue I have is there really needs to be some kind of page highlighting the differences in features, such as this change of per site switches feature.

@Gitoffthelawn

This comment has been minimized.

Copy link

Gitoffthelawn commented Jun 3, 2015

@chrcoluk wrote: "The issue I have is there really needs to be some kind of page highlighting the differences in features, such as this change of per site switches feature."

+1000
I don't have enough knowledge about the differences to do it myself, but if someone puts together a rough draft, I'm willing to edit it and polish it up. If the developers support the idea, I'm also willing to ask the right questions to make the differences clear to the average user. I will also work to ensure it is unbiased and written in a friendly way. I have no agenda, bias, ego involvement, or financial interest. Like most people, I just want the tool that best suits my needs.

@chrcoluk

This comment has been minimized.

Copy link

chrcoluk commented Jun 3, 2015

For what its worth I am now on ublock origin, I suspect this will become the better version over time. Although I hope this version gets the network log firefox ui enhancement the other version has.

On the other version there is also no mention of per site switches been removed in any changelogs, however it does look like they were "silently" removed, which to me isnt good behaviour from a developer, as the other ublock is still on my laptop and I see the 3 buttons underneath "domains connected" are missing. I will move my laptop over to this version as well soon, I only kept it on there for now to compare the two.

@gwarser

This comment has been minimized.

Copy link
Contributor

gwarser commented Jun 3, 2015

@chrcoluk

This comment has been minimized.

Copy link

chrcoluk commented Jun 3, 2015

ahh ok so the per site switcher was added specifically in this version, thanks.

@Gitoffthelawn

This comment has been minimized.

Copy link

Gitoffthelawn commented Jun 3, 2015

@gorhill wrote: "Main reason I published on AMO is because a feature which I think is important was removed from uBlock (per-site switches)."

Can you provide some detail as to where this feature is located and what function it serves? Chrcoluk mentioned the three buttons at the bottom of the uBlock popup. Is that what the functionality to which you are referring? Did regular uBlock remove the ability to control popups, strict filtering, and cosmetic filtering on a per-site basis? If so, why?

@Snapy

This comment has been minimized.

Copy link

Snapy commented Jun 3, 2015

Yes, the three buttons at the buttom are the per site switches.
Yes, regular uBlock removed them but you can still block popups through filter syntax ($popup) and disabling cosmetic filtering should (not sure) be possible through dynamic filtering (wiki page). Whereas strict filtering (actually strict blocking) is not available for now (well, only in the 0.9.3.0 release which is the same for both project).

geoffdutton pushed a commit to geoffdutton/uBlock that referenced this issue May 9, 2018

Merge pull request gorhill#38 from nikrolls/forward-background-downlo…
…ads-to-foreground

Send background downloads to the foreground
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.