Update urlchar to handle character escaping.#9
Merged
kisielk merged 2 commits intogorilla:masterfrom Jan 15, 2017
Merged
Conversation
Basic idea: urlchar should accept [(ascii characters minus those that need escaping)(non ascii characters)(escaped sequences)]. The 2 later parts are taken cared of by {nonascii} and {escape} macro already. Below is the broken down explanation for the first part:
ASCII characters range = [\u0020-\u007e]
Skip space \u0020 = [\u0021-\u007e]
Skip quotation mark \0022 = [\u0021\u0023-\u007e]
Skip apostrophe \u0027 = [\u0021\u0023-\u0026\u0028-\u007e]
Skip reverse solidus \u005c = [\u0021\u0023-\u0026\u0028-\u005b\u005d\u007e]
Also, the left square bracket (\u005b) and right (\u005d) needs escaping themselves, hence the final regex
Contributor
|
That seems reasonable to me. Can you include a description of the characters as you have done in this PR in the comments in the code? That will give people looking at it in the future some point of reference. |
Contributor
Author
|
@kisielk sure thing. |
Contributor
|
Cool. Thanks a lot! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic idea: urlchar should accept [(ascii characters minus those that need escaping)(non ascii characters)(escaped sequences)]. The 2 later parts are taken care of by {nonascii} and {escape} macro already. Below is the broken down explanation for the first part:
ASCII characters range =
[\u0020-\u007e]Skip space \u0020 =
[\u0021-\u007e]Skip quotation mark \0022 =
[\u0021\u0023-\u007e]Skip apostrophe \u0027 =
[\u0021\u0023-\u0026\u0028-\u007e]Skip reverse solidus \u005c =
[\u0021\u0023-\u0026\u0028-\u005b\u005d\u007e]Also, the left square bracket (\u005b) and right (\u005d) needs escaping themselves, hence the final regex