fix: guard routeRegexp.Match against nil receiver or regexp#803
Open
leno23 wants to merge 1 commit into
Open
Conversation
Fixes gorilla#749 Return false instead of panicking when routeRegexp or its compiled regexp is nil. Also skip variable extraction when query/host/path regexps are unset. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #749
Avoid panics in
(*routeRegexp).Matchwhen the receiver or compiledregexpfield is nil by returningfalseinstead.Also guards variable extraction in
routeRegexpGroup.setMatchandmatchQueryString.Test plan
go test ./...TestRouteRegexpMatchNilReceiverandTestRouteRegexpMatchNilRegexpMade with Cursor