Skip to content

fix(ENGKNOW-2060): Add MetricsMonitor and fix pipe headers.#38

Merged
gmagnu merged 6 commits intomainfrom
ENGKNOW-2060-missing-metrics-in-query-service
Feb 26, 2025
Merged

fix(ENGKNOW-2060): Add MetricsMonitor and fix pipe headers.#38
gmagnu merged 6 commits intomainfrom
ENGKNOW-2060-missing-metrics-in-query-service

Conversation

@gmagnu
Copy link
Contributor

@gmagnu gmagnu commented Feb 22, 2025

  • Add metrics monitor
  • Updated headers when steps added with pipe.
  • Fix Analysis.getHeader

@github-actions
Copy link

github-actions bot commented Feb 22, 2025

Junit Tests - Summary

4 244 tests  +4   4 079 ✅ +3   11m 30s ⏱️ +42s
  452 suites +2     165 💤 +1 
  452 files   +2       0 ❌ ±0 

Results for commit 4ad0035. ± Comparison against base commit 395b64d.

This pull request skips 1 test.
gorsat.UTestSignature ‑ testSignature10Seconds

♻️ This comment has been updated with latest results.


private def validateKeyOrder(r: Row, key: String, prevKey: String, source: String): Unit = {
if (prevKey != null && !prevKey.isEmpty && prevKey > key) {
if (prevKey != null && !prevKey.isEmpty && prevKey.compareTo(key) > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hraðvirkara?

Copy link
Contributor

@gumson gumson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmagnu gmagnu merged commit 1a7198b into main Feb 26, 2025
11 checks passed
@gmagnu gmagnu deleted the ENGKNOW-2060-missing-metrics-in-query-service branch February 26, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments