Skip to content

Support edit recommend pipeline via LogicFlow#1131

Merged
zhenghaoz merged 3 commits intomasterfrom
hot
Jan 4, 2026
Merged

Support edit recommend pipeline via LogicFlow#1131
zhenghaoz merged 3 commits intomasterfrom
hot

Conversation

@zhenghaoz
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for editing the recommendation pipeline configuration dynamically via LogicFlow by introducing a new REST API endpoint. The changes allow dashboard users to update recommendation settings at runtime and persist them to storage.

Key changes include:

  • Added a new POST endpoint /api/dashboard/config to update configuration
  • Implemented persistence of recommendation configuration to meta storage
  • Modified startup logic to load persisted recommendation configuration

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
storage/meta/database.go Adds a new constant RECOMMEND_CONFIG for storing recommendation configuration in meta storage
master/rest.go Implements the new postConfig endpoint handler to receive, decode, and persist configuration updates
master/master.go Adds logic during startup to load and apply persisted recommendation configuration from meta storage
master/rest_test.go Renames test method to TestConfig and adds test case for the new POST config endpoint
go.mod Updates dashboard dependency to version with date 2026-01-03
go.sum Updates checksums for the new dashboard dependency version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread master/rest.go
Comment thread master/rest.go
Comment thread master/rest.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 3, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.74%. Comparing base (6a55084) to head (462cb54).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
master/rest.go 60.52% 10 Missing and 5 partials ⚠️
master/master.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   71.73%   71.74%   +0.01%     
==========================================
  Files          86       86              
  Lines       15171    15216      +45     
==========================================
+ Hits        10883    10917      +34     
- Misses       3215     3219       +4     
- Partials     1073     1080       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhenghaoz zhenghaoz merged commit 0186811 into master Jan 4, 2026
12 checks passed
@zhenghaoz zhenghaoz deleted the hot branch January 4, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants