Introduce standalone gost_digest adaptor for provider#515
Merged
chipitsine merged 3 commits intogost-engine:masterfrom Mar 4, 2026
Merged
Introduce standalone gost_digest adaptor for provider#515chipitsine merged 3 commits intogost-engine:masterfrom
chipitsine merged 3 commits intogost-engine:masterfrom
Conversation
Ensure that test_digest validates which implementation (engine or provider) is actually being exercised.
Before this commit, test_digest invoked the engine-based digest implementation in both test-digest-engine and test-digest-provider, so the provider path was not actually exercised.
Add a new family of gost_digest* source files that implement an adaptor layer over gosthash and gosthash2012. This adaptor is used by gost_prov_digest and removes the dependency of gost_prov_digest on engine-specific code. In the future, the gost_digest* implementation may also replace gost_md/gost_md2012 in the engine backend.
Contributor
|
does not look severe, but ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the digest-related part of issue #505.
It introduces a new family of
gost_digest*source files implementing an adapter layer overgosthashandgosthash2012.The adapter is used by
gost_prov_digestand removes its dependency on engine-specific code.In the future, the
gost_digest*implementation may also replacegost_md/gost_md2012in the engine backend.This PR also fixes
test_digestto correctly test the provider implementation. Prior to this change,test_digestinvoked the engine-based digest implementation in bothtest-digest-engineandtest-digest-provider, so the provider code path was not actually tested.