fix(mtproxy): decrypt only bytes actually read in Obfuscated2.Read#1694
Merged
fix(mtproxy): decrypt only bytes actually read in Obfuscated2.Read#1694
Conversation
XORKeyStream(b, b) advanced the AES-CTR stream by len(b) instead of n, desyncing decryption when FakeTLS returns partial reads (one TLS record at a time). This corrupted all large MTProxy responses spanning multiple TLS records. Fixes #1139
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
- Coverage 68.51% 68.46% -0.06%
==========================================
Files 452 452
Lines 18910 18910
==========================================
- Hits 12957 12947 -10
- Misses 4987 4995 +8
- Partials 966 968 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This is great, thank you! Upd: the reason was in mtg version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XORKeyStream(b, b) advanced the AES-CTR stream by len(b) instead of n, desyncing decryption when FakeTLS returns partial reads (one TLS record at a time). This corrupted all large MTProxy responses spanning multiple TLS records.
Fixes #1139