fix(presets): fix Next.js Docker e2e test reliability#47
Merged
Conversation
- Add .dockerignore to exclude node_modules from build context (local macOS binaries overwrote Docker-installed ones via COPY . .) - Remove node_modules from copied fixture before Docker build - Use --no-cache flag to prevent stale Docker layer cache issues - Use dynamic port instead of hardcoded 3099 to avoid bind conflicts - Clean up stale containers from previous test runs before starting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.dockerignore,--no-cache, dynamic port, and stale container cleanupTest plan
cargo test --lib -p temps-presets— 192 passed, 0 failed