fix(cli): add hardcoded fallback for service required parameters#8
Merged
fix(cli): add hardcoded fallback for service required parameters#8
Conversation
The schema API call (GET /external-services/types/{type}/parameters) can
fail silently (returns { error } without throwing), leaving requiredFields
empty and causing service creation to still send parameters: {}.
Added KNOWN_REQUIRED_FIELDS fallback map so postgres and mongodb always
get database/username populated even when the schema fetch fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /external-services/types/{type}/parameters) returns{ error }without throwing, causingrequiredFieldsto stay emptyKNOWN_REQUIRED_FIELDShardcoded fallback map so PostgreSQL and MongoDB always getdatabaseandusernamepopulated regardless of whether the schema fetch succeedsRoot cause
The
@hey-apiclient doesn't throw on HTTP errors — it returns{ data: undefined, error: ... }. The previoustry/catchonly caught network-level exceptions, not API-level errors. When the schema call returned an error response,requiredFieldsstayed[]and no parameters were generated.Fix
Two-layer approach:
errorfrom the API response (not just rely ontry/catch)KNOWN_REQUIRED_FIELDS[serviceType]which mapspostgres→['database', 'username']andmongodb→['database', 'username']This ensures service creation works even if the schema endpoint is unreachable, returns an error, or changes format.