Bugfix: Loose app filter on screen rotation #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2022 20:30
View model provides data objects for messages activity and is not destroyed and recreated on screen rotation. So screen rotation should be a bit more faster.
jmattheis
approved these changes
Jan 30, 2022
Member
jmattheis
left a comment
jmattheis
left a comment
There was a problem hiding this comment.
Thanks for your 4th pull request!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a view model for the messages activity. It holds the objects which provide data to the view. The view model is not destroyed and recreated on screen rotation, so it is also used to hold the information about the selected app and therefore fixes #207. As well this should provide a slight performance improvement on screen rotation.