Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #959 +/- ##
==========================================
- Coverage 75.01% 74.93% -0.09%
==========================================
Files 61 62 +1
Lines 2886 2948 +62
==========================================
+ Hits 2165 2209 +44
- Misses 566 578 +12
- Partials 155 161 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if err := db.UpdateClientTokensLastUsed(connectedTokens, &now); err != nil { | ||
| log.Println("Error updating last used", err) | ||
| } | ||
| if expired, err := db.CleanupExpiredClients(now); err == nil { |
There was a problem hiding this comment.
I think as with last time we shouldn't have significant unusable precision on the schema.
If we can only process this every minute let use expiresAfter...Minutes or hours instead
| </TableCell> | ||
| <TableCell className="expires-in"> | ||
| {expiresAt ? ( | ||
| <TimeAgo date={expiresAt} formatter={TimeAgoFormatter.longMinutes} /> |
There was a problem hiding this comment.
Same thing, this format should be unified as minutes or hours, minutes.
I think the ability to glance through this column is more important than the exact timestamp represented in a changing formatting.
There was a problem hiding this comment.
Do you mean that the units for all rows are the same, so only hours and minutes are displayed even if the client expires in days or months?
There was a problem hiding this comment.
Yes, like all X hours, Y minutes or some other format that makes sense for scanning and glancing I think.
|
Another option for this to work precisely is to memoize an expiresAt field updated along with lastUsed, and predicate all client selections with a condition. |
2 participants
This MR includes:
fixes #943