Ignore LIBUSB_ERROR_INTERRUPTED in handleEvents to avoid unnecessary log spam#28
Merged
matthewrankin merged 1 commit intogotmc:masterfrom Nov 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the handleEvents loop to ignore harmless LIBUSB_ERROR_INTERRUPTED (EINTR) errors returned by libusb_handle_events_completed.
Background
LIBUSB_ERROR_INTERRUPTED occurs when a system call is interrupted by a signal. This is a normal and expected condition and not a fatal error. However, the current implementation logs this at every occurrence, which results in excessive log spam in long-running applications (e.g., daemons or agents using USB hotplug)
Example logs before this change:
2025/09/19 12:53:48 handle_events error: LIBUSB_ERROR_INTERRUPTED: System call interrupted (perhaps due to signal)
2025/09/19 13:00:48 handle_events error: LIBUSB_ERROR_INTERRUPTED: System call interrupted (perhaps due to signal)
...
Change
The fix adds a simple conditional check:
if errno := C.libusb_handle_events_completed(libCtx, nil); errno < 0 {
if ErrorCode(errno) == ErrorInterrupted {
// Ignore harmless EINTR instead of spamming logs
continue
}
log.Printf("handle_events error: %s", ErrorCode(errno))
}
Benefits
Keeps logs clean by ignoring expected EINTR interruptions.
All other error conditions continue to be logged normally.
Improves usability for production services without changing external behavior.