Skip to content

fix: track recipe duration in seconds #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudo-suhas merged 1 commit into from
Aug 4, 2023
Merged

fix: track recipe duration in seconds #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions metrics/otel_monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

// OtelMonitor represents the otel monitor.
type OtelMonitor struct {
recipeDuration metric.Int64Histogram
recipeDuration metric.Float64Histogram
extractorRetries metric.Int64Counter
assetsExtracted metric.Int64Counter
sinkRetries metric.Int64Counter
Expand All @@ -20,7 +20,7 @@ type OtelMonitor struct {
func NewOtelMonitor() *OtelMonitor {
// init meters
meter := otel.Meter("github.com/goto/meteor/metrics")
recipeDuration, err := meter.Int64Histogram("meteor.recipe.duration", metric.WithUnit("ms"))
recipeDuration, err := meter.Float64Histogram("meteor.recipe.duration", metric.WithUnit("s"))
handleOtelErr(err)

extractorRetries, err := meter.Int64Counter("meteor.extractor.retries")
Expand All @@ -43,7 +43,7 @@ func NewOtelMonitor() *OtelMonitor {
// RecordRun records a run behavior
func (m *OtelMonitor) RecordRun(ctx context.Context, run agent.Run) {
m.recipeDuration.Record(ctx,
int64(run.DurationInMs),
float64(run.DurationInMs)/1000.0,
metric.WithAttributes(
attribute.String("recipe_name", run.Recipe.Name),
attribute.String("extractor", run.Recipe.Source.Name),
Expand Down