Add is:inline directive to external script tags#19
Merged
Conversation
- Add is:inline to external script tags in do-olls page to silence astro(4000) hints about unprocessed scripts with attributes - Upgrade astro from ^5.17.3 to 6.1.3 (zero warnings, build passes) https://claude.ai/code/session_01Tek4Bbs9j1izXAfMJ9awfH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the
is:inlinedirective to three external script tags that load third-party libraries (WaveSurfer.js, WaveSurfer regions plugin, and OpenSheetMusicDisplay).Changes
is:inlinedirective to the WaveSurfer.js library script tagis:inlinedirective to the WaveSurfer.js regions plugin script tagis:inlinedirective to the OpenSheetMusicDisplay library script tagDetails
The
is:inlinedirective ensures these external scripts are inlined in the HTML output rather than being processed through Astro's module system. This is appropriate for third-party CDN-hosted libraries that are already optimized and should be loaded as-is without additional bundling or transformation.https://claude.ai/code/session_01Tek4Bbs9j1izXAfMJ9awfH