Skip to content
This repository was archived by the owner on Nov 9, 2021. It is now read-only.

Conversation

@quaziabdullah
Copy link

@quaziabdullah quaziabdullah commented Apr 16, 2020

This enables to have a json output from an existing Drupal menu as a rest endpoint (e.g. "/api/menu_items/main"). A good use-case is to integrate the menu structure while using any component based design.

@ruwanl ruwanl changed the title Add rest_menu_items module [GOVCMSD8-599] Add rest_menu_items module May 6, 2020
@drupal-spider
Copy link
Contributor

There is a major issue with version 8.x-2.9 (the latest stable version so far) that causes a fatal 500 error while trying to find uuid parameter from routed url.

More information about this bug:

https://www.drupal.org/project/rest_menu_items/issues/3085497

The patch to fix it:

https://www.drupal.org/files/issues/2019-10-03/3085497-Check-for-entity-type-when-getting-uuid.patch

The module maintainer has already added this path into the develop branch which means it will be fixed with next stable release of this module.

@drupal-spider
Copy link
Contributor

@drupal-spider
Copy link
Contributor

PHP 7.3 compatibility issues:

  • FILE: rest_menu_items/src/Plugin/rest/resource/RestMenuItemsCacheableDependency.php

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE


3 | WARNING | 'resource' is a soft reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)


  • FILE: rest_menu_items/src/Plugin/rest/resource/RestMenuItemsResource.php

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE


3 | WARNING | 'resource' is a soft reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)


@drupal-spider
Copy link
Contributor

drupal-spider commented May 21, 2020

The latest stable release (rest_menu_items 3.0.1) fixed following issues:

  • Menu link with hash value/anchor does not get included in response

  • Fixed an issue with error messages on clean installs

  • Error while getting entity type from routed URI

  • t() calls should be avoided in classes

  • Fixed a typo

  • Drupal 9 readiness

  • Added version constraint for Drupal because of semantic versioning for Drupal 9

Those two minor PHP 7.3 compatibility issues are actually coming from Drupal plugin namespace. Nothing need to do with this module.

drupal-spider
drupal-spider previously approved these changes May 21, 2020
Copy link
Contributor

@drupal-spider drupal-spider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Known issues have been addressed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants