Re-add linux-musl to Bundler platforms#1727
Merged
Conversation
lfdebrux
force-pushed
the
ldeb-update-bundler-platforms
branch
from
76dbedb to
afba9aa
Compare
In commit de10f10 we added *-linux-musl platforms to the Bundler lockfile, because the Alpine docker images we use in production are based on musl and a Nokogiri update started differentiating between linux-gnu and linux-musl platforms. However, in commit 8f725b3 a Depdenabot update removed those lines. This commit re-adds them, hopefully we can also find a way to stop Dependabot from removing them.
lfdebrux
force-pushed
the
ldeb-update-bundler-platforms
branch
from
afba9aa to
d77ba50
Compare
Bumps [bundler](https://bundler.io/) from 2.5.3 to 2.6.3. - [Release notes](https://github.com/rubygems/rubygems/releases/tag/bundler-v2.6.3) - [Changelog](https://github.com/rubygems/rubygems/blob/master/bundler/CHANGELOG.md) - [Commits](ruby/rubygems@bundler-v2.5.3...bundler-v2.6.2)
Ran `bundle lock --normalize-platforms`. See PR ruby/rubygems#7896 for details on what this does.
lfdebrux
force-pushed
the
ldeb-update-bundler-platforms
branch
from
7986182 to
86629e4
Compare
|
SamJamCul
approved these changes
Jan 24, 2025
Contributor
SamJamCul
left a comment
SamJamCul
left a comment
There was a problem hiding this comment.
Will keep an eye on dependabot in case it does any more nefarious deletions
This was referenced Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
In commit de10f10 we added *-linux-musl platforms to the Bundler lockfile, because the Alpine docker images we use in production are based on musl and a Nokogiri update started differentiating between linux-gnu and linux-musl platforms.
However, in commit 8f725b3 a Dependabot update removed those lines.
This PR re-adds them, hopefully we can also find a way to stop Dependabot from removing them. I also tried to clean up the list of platforms by running
bundle lock --normalize-platforms, which required first updating the version of Bundler used.Things to consider when reviewing