Get list of page routes in routes controller show action#1744
Merged
Conversation
Refactor code dealing with conditions and routes to abstract out getting conditions and routes for a page.
- Rename `all_routes` to `routes` - Move routes and conditional_routes to private methods - Add private method secondary_skip - Remove unnecessary class method `call`, use `new` instead
Change the routes/show action, view and RouteSummaryCardDataPresenter to get page routes up front and pass down the chain to other objects. This lets us use the list of routes in places other than the presenter.
|
thomasiles
approved these changes
Jan 31, 2025
Contributor
thomasiles
left a comment
thomasiles
left a comment
There was a problem hiding this comment.
Looks much neater, works locally and has some really nice ideas 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/6qRDmaOg/2095-changes-to-question-xs-routes-page-to-make-it-clearer
Change the routes/show action, view and RouteSummaryCardDataPresenter to get page routes up front and pass down the chain to other objects. This lets us use the list of routes in places other than the presenter.
Things to consider when reviewing