Add user research contact preference#1892
Merged
Merged
Conversation
|
thomasiles
force-pushed
the
add-user-research-contact-preference
branch
from
e5cfc92 to
8d3bbab
Compare
alice-carr
force-pushed
the
add-user-research-contact-preference
branch
6 times, most recently
from
83ce173 to
4ce5de7
Compare
alice-carr
force-pushed
the
add-user-research-contact-preference
branch
2 times, most recently
from
3cbecc2 to
25e7979
Compare
alice-carr
changed the title
alice-carr
force-pushed
the
add-user-research-contact-preference
branch
3 times, most recently
from
4471f0e to
0543f17
Compare
alice-carr
changed the title
alice-carr
force-pushed
the
add-user-research-contact-preference
branch
5 times, most recently
from
5ae990f to
144e63a
Compare
alice-carr
changed the title
hannahkc
reviewed
Sep 15, 2025
Contributor
|
Made one small content suggestion. Otherwise, all the content looks good. |
alice-carr
force-pushed
the
add-user-research-contact-preference
branch
2 times, most recently
from
91e5e2b to
f984889
Compare
DavidBiddle
previously approved these changes
Sep 16, 2025
alice-carr
force-pushed
the
add-user-research-contact-preference
branch
2 times, most recently
from
9c11cf0 to
6c8b364
Compare
alice-carr
force-pushed
the
add-user-research-contact-preference
branch
2 times, most recently
from
850346c to
1d15d09
Compare
Contributor
Author
|
This looks good to me, I can't add a review because I opened the PR. |
DavidBiddle
approved these changes
Sep 29, 2025
Contributor
DavidBiddle
left a comment
DavidBiddle
left a comment
There was a problem hiding this comment.
Code looks good and works for me in review 🎉
Add a new report which lists all users who have agreed to be contacted about user research. The list is ordered by date of sign up.
Add a new page and input object for user research contact preference.
Redirect any user who does not have contact_for_research set to the page to set it.
…search contact preference This commit adds the updated content for the contact for research page, as well as addidng tests for the contact for research controller It also adds a feature test to test the functionality of add a user research contact preference
… all users to "to_be_asked" - Adds a db migration and updated schema/seeds to default all users to "to_be_asked" - Adds timestamp to record what time the user opted into user research - sorts the users in the report that have consented by time of opting in to make it easier to keep track of users - updates the tests to reflect the new changes
alice-carr
force-pushed
the
add-user-research-contact-preference
branch
from
1d15d09 to
6be8a49
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-1892.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask new users for consent to be contacted about user research
Trello cards:
https://trello.com/c/8R5O8PTf/162-add-sign-up-screen-to-collect-user-research-interest
https://trello.com/c/ZBHqh34G/161-add-report-for-users-who-have-agreed-to-be-contacted-for-user-research
https://trello.com/c/6Vsps6ev/2380-design-and-build-the-new-opt-in-to-be-invited-to-take-part-in-ur-page-for-the-govuk-forms-signup-journey
This work was done during firebreak to add a report for users who have agreed to be contacted and a new form at the end of the signup journey which asks them.
Further work needed:
update content for consent (it's still being worked on) (done)add tests for the new controller and a feature test (done)think about deployment - we don't want to ask all users for their consent, only new ones(we've decided to ask all users for consent, not just new users)See this ticket for the final parts of implementation.
Things to consider when reviewing