Skip to content

Add notification banner when deleting route with exit page#2042

Merged
SamJamCul merged 1 commit into
mainfrom
348-add-a-banner-notification-warning-to-the-confirmation-page-when-deleting-a-route-that-goes-to-an-exit-page
Jul 2, 2025
Merged

Add notification banner when deleting route with exit page#2042
SamJamCul merged 1 commit into
mainfrom
348-add-a-banner-notification-warning-to-the-confirmation-page-when-deleting-a-route-that-goes-to-an-exit-page

Conversation

@SamJamCul
Copy link
Copy Markdown
Contributor

@SamJamCul SamJamCul commented Jun 27, 2025

Adds a notification banner to the delete-route page, when there's an exit page for that route.

This commit also uses the exit page heading in place of the goto page question text in the route summary, which would otherwise be blank (as exit page routes have no goto page)

What problem does this pull request solve?

Trello card: https://trello.com/c/9M6hc0mI/2348-add-a-banner-notification-warning-to-the-confirmation-page-when-deleting-a-route-that-goes-to-an-exit-page

Before


image ___

After


image ___

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@SamJamCul SamJamCul force-pushed the 348-add-a-banner-notification-warning-to-the-confirmation-page-when-deleting-a-route-that-goes-to-an-exit-page branch from 2f31d29 to 421fd80 Compare June 27, 2025 09:10
Copy link
Copy Markdown
Contributor

@thomasiles thomasiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SamJamCul SamJamCul force-pushed the 348-add-a-banner-notification-warning-to-the-confirmation-page-when-deleting-a-route-that-goes-to-an-exit-page branch from 421fd80 to a470db2 Compare June 30, 2025 14:42
@hannahkc
Copy link
Copy Markdown
Contributor

Content looks good 👍

Adds a notification banner to the delete-route page, when there's an exit page for that route.

This commit also uses the exit page heading in place of the goto page question text in the route summary, which would otherwise be blank (as exit page routes have no goto page)
@SamJamCul SamJamCul force-pushed the 348-add-a-banner-notification-warning-to-the-confirmation-page-when-deleting-a-route-that-goes-to-an-exit-page branch from a470db2 to 628e9ed Compare July 2, 2025 07:52
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 2, 2025

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 2, 2025

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2042.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@SamJamCul SamJamCul merged commit e15ef5d into main Jul 2, 2025
6 checks passed
@SamJamCul SamJamCul deleted the 348-add-a-banner-notification-warning-to-the-confirmation-page-when-deleting-a-route-that-goes-to-an-exit-page branch July 2, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants