Skip to content

Remove trailing slash from review app URL#2445

Merged
chao-xian merged 1 commit into
mainfrom
fix-review-app-url
Dec 18, 2025
Merged

Remove trailing slash from review app URL#2445
chao-xian merged 1 commit into
mainfrom
fix-review-app-url

Conversation

@chao-xian
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Review app URLs had // in them

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@chao-xian chao-xian marked this pull request as ready for review December 17, 2025 12:36
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2445.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@chao-xian chao-xian merged commit 85a3562 into main Dec 18, 2025
7 checks passed
@chao-xian chao-xian deleted the fix-review-app-url branch December 18, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants