Skip to content

Remove none of the above feature flag#2493

Merged
SamJamCul merged 1 commit into
mainfrom
remove-none-of-the-above-feature-flag
Jan 19, 2026
Merged

Remove none of the above feature flag#2493
SamJamCul merged 1 commit into
mainfrom
remove-none-of-the-above-feature-flag

Conversation

@SamJamCul
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

https://trello.com/c/QFWzMqeI/2773-remove-none-of-the-above-feature-flag?filter=label%3AFeature+team+two%2Clabel%3AX+feature+teams

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

Copy link
Copy Markdown
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny comments about some test names - 2 of which were already wrong but it would be worthwhile fixing

Comment thread spec/support/shared_examples/pages_selection_base_options_input.rb Outdated
Comment thread spec/views/pages/selection/bulk_options.html.erb_spec.rb Outdated
Comment thread spec/views/pages/selection/options.html.erb_spec.rb Outdated
@SamJamCul SamJamCul force-pushed the remove-none-of-the-above-feature-flag branch from 1c4d445 to 91687b6 Compare January 19, 2026 16:01
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2493.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@SamJamCul SamJamCul added this pull request to the merge queue Jan 19, 2026
Merged via the queue into main with commit 97968b4 Jan 19, 2026
7 checks passed
@SamJamCul SamJamCul deleted the remove-none-of-the-above-feature-flag branch January 19, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants