Remove unused 'size' attribute from hint text#2598
Merged
DavidBiddle merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
We were providing a 'hint' attribute to the hint text on the name settings page. This isn't supported by the design system or the `govuk_design_system_formbuilder` gem, so all it does is add an unsupported HTML attribute. This commit removes it.
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2598.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
thomasiles
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What problem does this pull request solve?
Trello card: https://trello.com/c/5l5thXNO/75-name-settings-page-hint-text-has-a-sizem-attribute
We were providing a 'hint' attribute to the hint text on the name settings page. This isn't supported by the design system or the
govuk_design_system_formbuildergem, so all it does is add an unsupported HTML attribute.This commit removes it.
Things to consider when reviewing