Skip to content

Remove unused 'size' attribute from hint text#2598

Merged
DavidBiddle merged 1 commit intomainfrom
remove-unused-size-attribute-from-hint
Mar 5, 2026
Merged

Remove unused 'size' attribute from hint text#2598
DavidBiddle merged 1 commit intomainfrom
remove-unused-size-attribute-from-hint

Conversation

@DavidBiddle
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle commented Mar 5, 2026

What problem does this pull request solve?

Trello card: https://trello.com/c/5l5thXNO/75-name-settings-page-hint-text-has-a-sizem-attribute

We were providing a 'hint' attribute to the hint text on the name settings page. This isn't supported by the design system or the govuk_design_system_formbuilder gem, so all it does is add an unsupported HTML attribute.

This commit removes it.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

We were providing a 'hint' attribute to the hint text on the name
settings page. This isn't supported by the design system or the
`govuk_design_system_formbuilder` gem, so all it does is add an
unsupported HTML attribute.

This commit removes it.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2026

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2598.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@DavidBiddle DavidBiddle added this pull request to the merge queue Mar 5, 2026
Merged via the queue into main with commit 3c9c2af Mar 5, 2026
8 checks passed
@DavidBiddle DavidBiddle deleted the remove-unused-size-attribute-from-hint branch March 5, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants