Conversation
We no longer need the assets from before the GOV.UK rebrand.
Slightly tweak the ERB for the header component so that the result of `header.with_product_name` is not treated as content of the header. With GOV.UK Components for Ruby on Rails 6.0.0 this was resulting in the product name appearing twice in the header.
Bumps [govuk-frontend](https://github.com/alphagov/govuk-frontend/tree/HEAD/packages/govuk-frontend) from 5.14.0 to 6.0.0. - [Release notes](https://github.com/alphagov/govuk-frontend/releases) - [Changelog](https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md) - [Commits](https://github.com/alphagov/govuk-frontend/commits/v6.0.0/packages/govuk-frontend) --- updated-dependencies: - dependency-name: govuk-frontend dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [govuk-components](https://github.com/x-govuk/govuk-components) from 5.13.1 to 6.0.0. - [Release notes](https://github.com/x-govuk/govuk-components/releases) - [Commits](x-govuk/govuk-components@v5.13.1...v6.0.0) --- updated-dependencies: - dependency-name: govuk-components dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [govuk_design_system_formbuilder](https://github.com/x-govuk/govuk-form-builder) from 5.13.0 to 6.0.0. - [Release notes](https://github.com/x-govuk/govuk-form-builder/releases) - [Commits](x-govuk/govuk-form-builder@v5.13.0...v6.0.0) --- updated-dependencies: - dependency-name: govuk_design_system_formbuilder dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Add configuration for GOV.UK Components for Ruby on Rails [[1]] so we can set the default header homepage. In govuk-components 6.0.0 the default was changed from the app root to GOV.UK [[2]], to match the same change in GOV.UK Frontend 6.0.0 [[3]]. [1]: https://govuk-components.netlify.app/introduction/configuration/ [2]: x-govuk/govuk-components#626 [3]: alphagov/govuk-frontend#6418
- Remove references to the `$govuk-new-typography-scale` feature flag - Use the `govuk-colour` function to access tints and shades - Update any light blue, turquoise or pink tags - Use `govuk-functional-colour` to access functional colours - Remove rebrand switch from template - Move rebranded assets
229553e to
0bb2427
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2626.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
stephencdaly
left a comment
There was a problem hiding this comment.
Changes all match the recommendations in the govuk-frontend release notes and I've tested using the review app and everything looks to be displayed correctly.



What problem does this pull request solve?
Trello card: https://trello.com/c/xibMInKA/2869-upgrade-govuk-frontend-to-v6
This PR updates our dependencies and our code so we can use GOV.UK Frontend 6.0.0.
See the commits for details on the changes made.
After these changes, there were a few visual differences I noticed:
There are a few issues that I'm aware of but that probably don't need to be fixed in this PR:
<header>element [6]@importsThings to consider when reviewing