Skip to content

Use email field type for submission and support email#2643

Merged
DavidBiddle merged 2 commits intomainfrom
use-email-field-type
Mar 23, 2026
Merged

Use email field type for submission and support email#2643
DavidBiddle merged 2 commits intomainfrom
use-email-field-type

Conversation

@DavidBiddle
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle commented Mar 18, 2026

What problem does this pull request solve?

Trello card: https://trello.com/c/0DkdzTzB/3399-submission-email-field-is-a-plain-text-field-not-an-email-field

Uses the 'email' input type for the submission and support email addresses.

Visually they look the same, but some mobile browsers will respond to the email input type by prompting the user with an email keyboard (where things like the @ and domain suffixes are more prominent). This means entrering an email address requires fewer keystrokes, which is a general usability improvement but can particularly make life easier for users with motor disabilities.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@DavidBiddle DavidBiddle force-pushed the use-email-field-type branch 2 times, most recently from 955303f to 2595b5b Compare March 19, 2026 15:53
@DavidBiddle DavidBiddle marked this pull request as ready for review March 19, 2026 15:55
@lfdebrux
Copy link
Copy Markdown
Contributor

Any reason not to change the field to add a new member to a group as well?

DavidBiddle and others added 2 commits March 23, 2026 10:06
Co-authored-by: Laurence de Bruxelles <laurence.debruxelles@digital.cabinet-office.gov.uk>
@DavidBiddle DavidBiddle force-pushed the use-email-field-type branch from 2595b5b to e4c2ace Compare March 23, 2026 10:06
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2643.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@DavidBiddle
Copy link
Copy Markdown
Contributor Author

@lfdebrux Good spot, have pushed that change now!

@DavidBiddle DavidBiddle added this pull request to the merge queue Mar 23, 2026
Merged via the queue into main with commit 17bbe48 Mar 23, 2026
5 checks passed
@DavidBiddle DavidBiddle deleted the use-email-field-type branch March 23, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants