Add ability to enable receiving weekly submission batches#2652
Merged
stephencdaly merged 6 commits intomainfrom Mar 26, 2026
Merged
Add ability to enable receiving weekly submission batches#2652stephencdaly merged 6 commits intomainfrom
stephencdaly merged 6 commits intomainfrom
Conversation
When enabled, we will show the option to get weekly submission batches.
stephencdaly
force-pushed
the
add-ui-for-enabling-weekly-submissions
branch
2 times, most recently
from
a102afe to
5de0a95
Compare
lfdebrux
reviewed
Mar 25, 2026
stephencdaly
force-pushed
the
add-ui-for-enabling-weekly-submissions
branch
2 times, most recently
from
0e72c83 to
3f8c584
Compare
lfdebrux
reviewed
Mar 25, 2026
stephencdaly
force-pushed
the
add-ui-for-enabling-weekly-submissions
branch
from
3f8c584 to
4858da8
Compare
lfdebrux
reviewed
Mar 25, 2026
If the weekly_submission_emails_enabled feature flag is enabled, show an additional checkbox to enable sending weekly batches of submissions. If the feature flag is disabled, continue showing a single checkbox. Use different content on the page depending on whether the feature flag is enabled or not.
If the weekly_submission_emails_enabled feature flag is enabled, display a success message when the batch submissions settings are changed depending on which settings were enabled or disabled. Continue to show the old success message if the feature flag is disabled.
Return "completed" status for the task to enable batch submissions if either daily or weekly batches are enabled.
If the weekly_submission_emails_enabled feature flag is enabled, display different content for teh batch submissions task list item.
Update the content displayed on the live form page when the weekly_submission_emails_enabled feature flay is enabled to have a different title and a paragraph describing which combination of daily and weekly batches are enabled.
stephencdaly
force-pushed
the
add-ui-for-enabling-weekly-submissions
branch
from
4858da8 to
07c108e
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2652.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
hannahkc
approved these changes
Mar 25, 2026
Contributor
hannahkc
left a comment
hannahkc
left a comment
There was a problem hiding this comment.
All the content looks perfecto! Thanks!
lfdebrux
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/6ebxtzqO
Adds a weekly_submission_emails_enabled feature flag that these changes are behind.
If the feature flag is enabled:
Things to consider when reviewing