Remove DefaultGroupService#2694
Merged
Merged
Conversation
stephencdaly
force-pushed
the
remove-code-to-add-forms-to-default-group
branch
from
61708c2 to
87059ee
Compare
This service existed because Forms orginially were not created in groups. When groups were added, we moved all live forms for users who were a member of an organisation into a group for their organisation, and draft forms into a trial group for the user. There were some users that had not selected an organisation, so their forms were not moved into groups. The DefaultGroupService was used to move those forms into a default trial group for the user after they selected their organisation. There are no longer any forms that don't have a group, so this code can be removed.
stephencdaly
force-pushed
the
remove-code-to-add-forms-to-default-group
branch
from
87059ee to
9058e46
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2694.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This service existed because Forms orginially were not created in groups. When groups were added, we moved all live forms for users who were a member of an organisation into a group for their organisation, and draft forms into a trial group for the user.
There were some users that had not selected an organisation, so their forms were not moved into groups. The DefaultGroupService was used to move those forms into a default trial group for the user after they selected their organisation.
There are no longer any forms that don't have a group, so this code can be removed.
Things to consider when reviewing