Skip to content

Add API endpoint to get the group for a form#2748

Merged
stephencdaly merged 1 commit intomainfrom
add-api-endpoint-for-getting-contact-details-for-group
May 7, 2026
Merged

Add API endpoint to get the group for a form#2748
stephencdaly merged 1 commit intomainfrom
add-api-endpoint-for-getting-contact-details-for-group

Conversation

@stephencdaly
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/CsEqMtDL

Add an API endpoint that returns the group details for the form with the given ID. This includes the group admin users, and the organisation details including the organisation admin users as embedded resources.

This endpoint will be used by forms-runner to get the group and organisation details for the form and the contact details for the group and organisation admin users in order to send email notifications when submissions bounce.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

Comment thread spec/requests/api/form_documents_controller_spec.rb Outdated
lfdebrux
lfdebrux previously approved these changes May 6, 2026
Add an API endpoint that returns the group details for the form with
the given ID. This includes the group admin users, and the
organisation details including the organisation admin users as
embedded resources.

This endpoint will be used by forms-runner to get the group and
organisation details for the form and the contact details for the
group and organisation admin users in order to send email
notifications when submissions bounce.
@stephencdaly stephencdaly force-pushed the add-api-endpoint-for-getting-contact-details-for-group branch from ace3655 to 6f83d3a Compare May 6, 2026 14:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2748.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@stephencdaly stephencdaly added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 575deef May 7, 2026
3 checks passed
@stephencdaly stephencdaly deleted the add-api-endpoint-for-getting-contact-details-for-group branch May 7, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants