Update add edit routes content#2774
Merged
Merged
Conversation
SamJamCul
force-pushed
the
update-add-edit-routes-content
branch
from
0f5fcc8 to
5ec0e5d
Compare
lfdebrux
reviewed
May 13, 2026
lfdebrux
previously approved these changes
May 13, 2026
Updates the content for the Add and edit questions view behind the multiple_branches feature flag. Questions with multiple conditions will have their conditions displayed in groupings based on the destination for those conditions. Groups are displayed in the order of their destination question positions, with the skip to end group always set as the final group. Also updates the content for unconditional routes.
The summary list key will be either singular or plural depending on how many conditions are present for that question.
SamJamCul
force-pushed
the
update-add-edit-routes-content
branch
from
5ec0e5d to
68a1856
Compare
lfdebrux
previously approved these changes
May 13, 2026
Contributor
|
content in the screenshots all looks good to me! |
This group has the feature flag enabled so that changes behind the flag can be seen.
SamJamCul
force-pushed
the
update-add-edit-routes-content
branch
from
756b1b2 to
1f12886
Compare
lfdebrux
approved these changes
May 13, 2026
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2774.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
https://trello.com/c/IgUz33Ml/3070-make-edit-questions-list-display-with-new-routes-and-content-update
Updates to the content for the Add and edit questions page for multiple branches. This does not handle exit pages at all.
Additionally, the list of answer values, when there are multiple that lead to the same page, is not ordered, and will shuffle around if routes are added and deleted. I found it was a bit fiddly to try and fix that, I'll take another crack at it in a bit.
When a page has a single condition based on an answer value
Note also that the key shows it's a singular
routeWhen a page has multiple conditions
Conditions are grouped by their destination page's position, with skip to end conditions at the end. The key also shows that there are multiple routes, so uses the plural
Unconditional route to a question
Unconditional skip to the end
Things to consider when reviewing