Order selection options#2788
Merged
Merged
Conversation
Change the spec for PageListComponent::View#answer_value_groups to use a stub form and pages, rather than using create. This is a bit longer but making it more explicit will let us change the order of the options later. Supplying the selection_options like this ensures lets us build valid conditions for the page. Not using create speeds up the tests.
We want to display the conditions for a page on the page list in the same order as the selection options on the page. To do this, we get a list of selection options from the page's answer settings, and then use this list to sort the conditions. We turn off the filter for the call to `in_order_of` so that any extra conditions are included, even if they aren't included in the order. group_by preservers order when given an array so we are safe to use it like this. We still sort by the `goto_page_id` so that the conditions are grouped by the page they go to and nil comes last.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2788.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/x0opnWol/3108-order-condition-description-answer-values-based-on-selection-options
In the pagelist view, show routes in the same order as the page's selection options.
Things to consider when reviewing