Skip to content

Fix content for none of the above option when adding and editing routes#2797

Merged
lfdebrux merged 3 commits into
mainfrom
ldeb-none-of-the-above-condition-content
May 27, 2026
Merged

Fix content for none of the above option when adding and editing routes#2797
lfdebrux merged 3 commits into
mainfrom
ldeb-none-of-the-above-condition-content

Conversation

@lfdebrux
Copy link
Copy Markdown
Contributor

@lfdebrux lfdebrux commented May 20, 2026

What problem does this pull request solve?

While working on multiple branches, we noticed that the existing routing implementation is missing content for the situation when the answer value for a condition is the none of the above option for an optional selection question; the pages rendered the answer value as none_of_the_above.

This PR adds the missing content.

Screenshots

Showing a route

Screenshot of http://localhost:3000/forms/8/pages/31/routes

Deleting a route

Screenshot of http://localhost:3000/forms/8/pages/31/conditions/11/delete

Adding a secondary skip to a route

Screenshot of http://localhost:3000/forms/8/pages/31/routes/any-other-answer/questions-to-skip/new

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2797.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@hannahkc
Copy link
Copy Markdown
Contributor

Content looks grand - thank so much for doing this!

Copy link
Copy Markdown
Contributor

@SamJamCul SamJamCul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to get this stuff cleaned up

@lfdebrux lfdebrux added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit 737bc08 May 27, 2026
6 checks passed
@lfdebrux lfdebrux deleted the ldeb-none-of-the-above-condition-content branch May 27, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants