This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Remove feature usage report endpoint#726
Merged
stephencdaly merged 2 commits intomainfrom Apr 4, 2025
Merged
Conversation
stephencdaly
force-pushed
the
remove-features-report-endpoint
branch
from
7c340e4 to
c784463
Compare
lfdebrux
previously approved these changes
Apr 4, 2025
Contributor
lfdebrux
left a comment
lfdebrux
left a comment
There was a problem hiding this comment.
Yay for deleting things!
Contributor
|
@stephencdaly Can we remove the endpoint from |
This report is now constructed in forms-admin using data retrieved from `api/v2/form_documents` and so this endpoint is no longer consumed.
Rename the `FeatureUsageService` to `AddAnotherAnswerUsage` service as this is the only thing it is now used for.
stephencdaly
force-pushed
the
remove-features-report-endpoint
branch
from
c784463 to
4cd5ea4
Compare
|
Contributor
Author
Ah good spot, thanks! Have removed. |
lfdebrux
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/SgDCKXcY/145-improve-our-feature-reports
This report is now constructed in forms-admin using data retrieved from
api/v2/form_documentsand so this endpoint is no longer consumed.Rename the
FeatureUsageServicetoAddAnotherAnswerUsageservice as this is the only thing it is now used for.Things to consider when reviewing