Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Set the owner of the /app/tmp and /tmp volumes in the Dockerfile#764

Merged
AP-Hunt merged 1 commit into
mainfrom
set-owner-of-docker-volumes
May 23, 2025
Merged

Set the owner of the /app/tmp and /tmp volumes in the Dockerfile#764
AP-Hunt merged 1 commit into
mainfrom
set-owner-of-docker-volumes

Conversation

@AP-Hunt
Copy link
Copy Markdown
Contributor

@AP-Hunt AP-Hunt commented May 23, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/KoHvaEUA/681-aws-m112-ecs-read-only-root-filesystem-configuration

AWS ECS documentation [1] shows how volume ownership should be set

[1] https://docs.aws.amazon.com/AmazonECS/latest/developerguide/bind-mounts.html

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@AP-Hunt AP-Hunt force-pushed the set-owner-of-docker-volumes branch from 8ffdf01 to 74156d0 Compare May 23, 2025 14:39
@sonarqubecloud
Copy link
Copy Markdown

@AP-Hunt AP-Hunt merged commit 56d3c54 into main May 23, 2025
4 checks passed
@AP-Hunt AP-Hunt deleted the set-owner-of-docker-volumes branch May 23, 2025 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant