Create SolidQueue worker Sentry DSN secret#1591
Merged
Merged
Conversation
* Create a SSM parameter store entry for the SolidQueue worker Sentry DSN * This should be applied before other SolidQueue work ECS task configuration so that the ECS task can access the correct value on creation
5 tasks
cadmiumcat
approved these changes
Jun 3, 2025
Contributor
cadmiumcat
left a comment
cadmiumcat
left a comment
There was a problem hiding this comment.
👍
I'll make sure to add it to the secret audit file
sarahseewhy
added a commit
that referenced
this pull request
Jun 4, 2025
* Add SSM parameter created from PR #1591 * I rebased PR #1591 on to this branch in the GitHub UI (not a good idea), and it absorbed the queue_worker.tf file from PR #1591 as a separate file instead of merging the files together. * This happened because I didn't take into account the lack of shared file history from git's perspective. * The queue_worker.tf on the `create-solidqueue-worker-ecs-task` branch was never branched off from the queue_worker.tf in main (i.e., it was created independently rather than modified from the original). Therefore, Git doesn’t know they’re related. It treats them as two different files that just happen to have the same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/f7js82Cm/635-run-solid-queue-as-its-own-ecs-task
Once applied we will need to pair on manually adding the secrets in the relevant environments.
Things to consider when reviewing