Skip to content

BAU: Ensure that actions are pinned to SHAs#1686

Merged
whi-tw merged 2 commits into
mainfrom
whi-tw/require-pinned-gha
Nov 7, 2025
Merged

BAU: Ensure that actions are pinned to SHAs#1686
whi-tw merged 2 commits into
mainfrom
whi-tw/require-pinned-gha

Conversation

@whi-tw
Copy link
Copy Markdown
Contributor

@whi-tw whi-tw commented Oct 21, 2025

What problem does this pull request solve?

This will flag that non-sha-pinned actions are present in workflows. SHA-pinning is advised in GDS-way.

@whi-tw whi-tw force-pushed the whi-tw/require-pinned-gha branch 5 times, most recently from e674697 to 19c0853 Compare October 21, 2025 15:11
@whi-tw whi-tw requested a review from lfdebrux October 21, 2025 15:13
@whi-tw whi-tw force-pushed the whi-tw/require-pinned-gha branch from 19c0853 to bfa3c3f Compare October 22, 2025 08:06
DavidBiddle
DavidBiddle previously approved these changes Nov 7, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 7, 2025

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@whi-tw whi-tw force-pushed the whi-tw/require-pinned-gha branch from c8f06d3 to ba01fe6 Compare November 7, 2025 10:12
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 7, 2025

@whi-tw whi-tw merged commit 5d6fe49 into main Nov 7, 2025
6 of 7 checks passed
@whi-tw whi-tw deleted the whi-tw/require-pinned-gha branch November 7, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants