Store Welsh from document on submission#2111
Merged
Merged
Conversation
In order to send confirmation emails with a copy of the user's answers in Welsh, we need to store the Welsh version of the form document at the time of submission in order to get the Welsh translations for the questions that exist in the form at that moment in time. This is necessary as we send confirmation emails asynchronously using ActiveJob, so cannot retrieve the document from forms-admin at the time of sending as it may have changed since the submission.
If Welsh has been used when completing the form, store the Welsh form document on the submission. If we've already loaded the Welsh form document, we can use that - otherwise retrieve it from forms-admin.
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2111.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
stephencdaly
changed the title
chao-xian
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/hCWhyMOm
In order to send confirmation emails with a copy of the user's answers in Welsh, we need to store the Welsh version of the form document at the time of submission in order to get the Welsh translations for the questions that exist in the form at that moment in time.
This is necessary as we send confirmation emails asynchronously using ActiveJob, so cannot retrieve the document from forms-admin at the time of sending as it may have changed since the submission.
Things to consider when reviewing