Develop#2
Merged
ralvescosta merged 2 commits intomainfrom May 28, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the distributed tracing implementation, simplifying the codebase and modularizing the functionality into separate packages. Key changes include the removal of the
OTLPTracingBuilderabstraction, the introduction of modularInstallmethods for OTLP and Noop tracing, and the reorganization of files into distinct packages (amqp,otlp,noop,stdout, andzap).Refactoring and Modularization:
Removal of
OTLPTracingBuilderabstraction: Theotlp.gofile was completely rewritten to remove the builder pattern and replace it with a simplerInstallfunction for configuring OTLP tracing. This significantly reduces complexity and improves maintainability. (otlp.goremoved in [1] new implementation added inotlp/otlp.goin [2]Introduction of modular
Installmethods: ModularInstallmethods were introduced for OTLP (otlp/otlp.go) and Noop tracing (noop/noop.go), enabling clear separation and easier integration based on configuration. (noop/noop.goadded in [1]otlp/otlp.goadded in [2]File Organization:
amqp,otlp,noop,stdout, andzapfor better modularization. For example,amqp.gowas renamed toamqp/amqp.go, andlog.gowas renamed tozap/log.go. (amqp/amqp.gorenamed in [1]zap/log.gorenamed in [2]Simplification of Tracing Logic:
Installmethod intracing.gonow delegates tracing setup to either the OTLP or Noop implementation based on configuration, removing the need for complex builder patterns. (tracing.gomodified in tracing.goL10-R21)New Package Introductions:
stdoutandnoopwere introduced to encapsulate specific tracing implementations. (stdout/stdout.goadded in [1]noop/noop.goadded in [2]