Solved ClassCastException in deepCopy() and equals() that prevented somehow deletion of instances #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you very much for your fix. I'll merge tonight and generate a new version of the plugin. Regards, Iván. |
Collaborator
|
I've cleanup all (removed Do you want me to generate a new version with all the commits in your PR or do you want to do some additional tests? For me it's ok to generate the new version. Regards, Iván. |
Contributor
Author
|
A new version is ok for me too, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've enforced type checking in HstoreDomainType methods in order to make a correct type cast.
A test that check instance deletion is attached, so far I've noticed no regressions.
This should solve issue #28.