Move to trash on deletion

[Thlayli]

I'm starting to come out of shock and get angry. I just changed the URL of a feed, and since I couldn't change the feed URL in Podcast settings, I decided to delete and re-add the feed. It warned me about deleting files, but I assumed the worst it would do is delete the 15 or so items I'd downloaded from Gpodder. Apparently that warning means "we're about to remove 76GB of data that was already in that folder without even using the recycle bin."

WHAT THE HECK POLICY IS THAT?

[Thlayli]

Well, I've moved past shock and anger and am running bargaining (Recuva) right now. Might as well get to acceptance. Please implement the following recycle bin code, or similar, so it doesn't permanently delete anyone else's entire collection of TV shows. Alternatively, clarify dialog box when removing a feed to say "entire directory, including any files that were already there before you installed Gpodder, will be permanently deleted" 👅

http://www.hardcoded.net/articles/send-files-to-trash-on-all-platforms.htm

[elelay]

I don't use a trashcan on my system so I wouldn't want this (would have to manually empty the trash). But I understand we should leave files unknown to gPodder untouched when deleting a podcast.

[adamvoss]

I think the language contradicts the behavior, but I agree with the behavior. See #270 for my thoughts on the naming issue.

Unless you really go digging in the wiki to find the right environment variable to set up, the gPodder download directory exists within GPODDER_HOME, together with other gPodder files, and consistent with the fact the files are managed and governed by gPodder. This is similar to how how Calibre manages Calibre Library and iTunes manages iTunes Music (or whatever the name is now that iTunes does so much more than music). It is reasonable to expect gPodder controls these files. On startup, it emits warnings (to log) when unknown external files are found and will also automatically associate external files it can match to podcast episodes even if they were not downloaded via gPodder. I have been known to access my podcast episodes from external HDD without gPodder installed and appreciate that it keeps the podcast folder [that it manages] clean.

Regarding the Trash/Recycling Bin behavior, I agree with @elelay, that I would want direct deletion. I also recognize that many users do appreciate use of a Recycle Bin, so I think it would be acceptable to either:

• make the deletion dialog have a check-box to indicate permanent delete is desired, or
• have separate menu entries "Move podcast to trash" and "Delete podcast" from which the user can choose (a la Amarok).

#270 would be a pretty easy change for anyone to do. Implementing the Recycle Bin/Trash behavior would be more involved. While I prefer that gPodder deletes the whole folder, if someone submits a PR making it delete only known files, I would still merge it and it would become that be the accepted behavior. PRs are welcome.