fix: stop changing icon during chat #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the chat icon would change based on the tool that was being called. For example, if an assistant was using a tool that needed to prompt the user, then the icon would change to the initials for that tool. After this change, the icon will only change when the assistant changes. A side effect that is also addressed in this change: restoring a thread now has the correct icons for the messages. This will only be true for threads created after this change. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
requested review from
StrongMonkey,
cjellick,
g-linville,
iwilltry42 and
njhale
thedadams
commented
Aug 22, 2024
| "main": "electron/main.mjs", | ||
| "dependencies": { | ||
| "@gptscript-ai/gptscript": "^0.9.5-rc4", | ||
| "@gptscript-ai/gptscript": "github:gptscript-ai/node-gptscript#0ec49d9df04627afe4518f4689dc212c0d03cdd6", |
There was a problem hiding this comment.
I had to fix an issue in node-gptscript to get the respondingTool stuff to work correctly.
g-linville
approved these changes
Aug 22, 2024
StrongMonkey
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the chat icon would change based on the tool that was being called. For example, if an assistant was using a tool that needed to prompt the user, then the icon would change to the initials for that tool. After this change, the icon will only change when the assistant changes.
A side effect that is also addressed in this change: restoring a thread now has the correct icons for the messages. This will only be true for threads created after this change.