fix: stop flashing Tildy assistant name when loading custom assistants #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
StrongMonkey,
g-linville,
njhale and
ryanhopperlowe
thedadams
commented
Aug 28, 2024
| function RunFile() { | ||
| const [script, _setScript] = useState<string>( | ||
| useSearchParams().get('file') ?? tildy | ||
| useSearchParams().get('file') ?? '' |
There was a problem hiding this comment.
Changing this is really all I wanted to do. However, this caused a bunch of errors to start popping up on launch, staring with the getMe stuff.
Most of the other changes are resolving the errors that popped up as a result.
njhale
approved these changes
Aug 28, 2024
StrongMonkey
approved these changes
Aug 28, 2024
contexts/chat.tsx
Outdated
| setThread(newThread.meta.id); | ||
| setSelectedThreadId(newThread.meta.id); | ||
| setWorkspaceDir(newThread.meta.workspace); | ||
| setWorkspaceDir(newThread.meta.workspace).then(); |
There was a problem hiding this comment.
Will remove. This was just a to get rid of a squiggly line that was bothering me.
contexts/chat.tsx
Outdated
| const newThread = await createThread( | ||
| script, | ||
| scriptDisplayName ?? defaultScriptName, | ||
| script !== '' ? script : tildy, |
There was a problem hiding this comment.
can be script ? script : tildy? Are you specifially checking undefined option?
There was a problem hiding this comment.
I'll update this.
There was a problem hiding this comment.
I know it's already merged, but a slightly better solution could be script || tildy. in JavaScript '' is a falsy value
No need for change though
Signed-off-by: Donnie Adams <donnie@acorn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.