Conversation
Collaborator
Author
|
This adds an index on the runs table. In my local testing, this reduced the load time for the main page from 2.5 seconds to about 500 ms. The Heroku database servers are a little slower than my local setup, so in Heroku I would expect the load time to go from 3.5 seconds to about 700 ms. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a database migration to add an index on the runs table in order to improve the main page's load time.
- Added migration file to create an index on leaderboard.runs based on the runner and score columns.
- Established a dependency on a previous migration to ensure sequence integrity.
Comments suppressed due to low confidence (1)
src/discord-cluster-manager/migrations/20250506_01_38PkG-add-index-on-runs-runner-score.py:10
- Confirm that the schema 'leaderboard' is the intended target for the runs table, especially if other parts of the system refer to the table without an explicit schema.
step(
"CREATE INDEX IF NOT EXISTS runs_runner_score_idx ON leaderboard.runs(runner, score)",
msaroufim
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an index on the runs table to reduce the load time for the main page.
Checklist
Before submitting this PR, ensure the following steps have been completed:
/verifyrunson your own server./verifyruns.runs may take a little longer. The Modal run is typically quick.)
For more information on running a cluster bot on your own server, see
README.md.