Fix: correct db access#307
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes API issues by correcting the database access patterns.
- Removed the context manager decorator from get_db and now return the database directly.
- Updated the prepare_submission call to pass the entire backend instead of just backend.db.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/discord-cluster-manager/api/main.py | Removed contextmanager usage in get_db and adjusted exception format. |
| src/discord-cluster-manager/api/api_utils.py | Changed prepare_submission parameter from backend.db to backend. |
Comments suppressed due to low confidence (2)
src/discord-cluster-manager/api/main.py:73
- The get_db function no longer functions as a context manager; please update its docstring to reflect that it now directly returns the database instance.
return backend_instance.db
src/discord-cluster-manager/api/api_utils.py:142
- Ensure that prepare_submission is updated accordingly to handle the full backend object instead of just the database property, as this change modifies the expected parameter type.
req = prepare_submission(submission, backend)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes api issues.