Update amd-docker.Dockerfile

[danielhua23]

No description provided.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
src/libkernelbot
utils.py
Project Total

This report was generated by python-coverage-comment-action

[Copilot]

Pull request overview

Updates the AMD runner Docker image build to parameterize ROCm kernel compilation for the aiter dependency via build-time arguments.

Changes:

• Add a GPU_ARCH build arg and export it as GPU_ARCH_LIST in the image environment.
• Add a PREBUILD_KERNELS build arg and pass it (along with GPU arch and MAX_JOBS) into aiter’s setup.py develop invocation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

ARG GPU_ARCH="gfx950" will include the quote characters in the default value (Dockerfile instructions don’t do shell-style unquoting). That can propagate to GPU_ARCH_LIST/GPU_ARCHS and break downstream parsing. Use an unquoted default (e.g., ARG GPU_ARCH=gfx950) and reference it via ${GPU_ARCH} when setting the ENV to avoid accidental literal characters.

Suggested change

	ARG GPU_ARCH="gfx950"
	ENV GPU_ARCH_LIST=$GPU_ARCH
	ARG GPU_ARCH=gfx950
	ENV GPU_ARCH_LIST=${GPU_ARCH}

[Copilot]

sudo MAX_JOBS=64 PREBUILD_KERNELS=... GPU_ARCHS=... python3 ... won’t set those variables for the python3 process; the assignments are treated as arguments to sudo, which typically causes sudo: MAX_JOBS=64: command not found and breaks the image build. Set the environment on the command side (e.g., MAX_JOBS=64 ... sudo python3 ...) or use sudo env MAX_JOBS=64 PREBUILD_KERNELS=... GPU_ARCHS=... python3 ....

Suggested change

	&& sudo MAX_JOBS=64 PREBUILD_KERNELS=$PREBUILD_KERNELS GPU_ARCHS=$GPU_ARCH_LIST python3 setup.py develop
	&& sudo env MAX_JOBS=64 PREBUILD_KERNELS=$PREBUILD_KERNELS GPU_ARCHS=$GPU_ARCH_LIST python3 setup.py develop