Skip to content

Tighten rtol/atol from 1e-2 to 1e-3 for Helion kernels #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msaroufim merged 1 commit into from
Mar 14, 2026
Merged

Tighten rtol/atol from 1e-2 to 1e-3 for Helion kernels #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion problems/helion/causal_conv1d_py/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ def ref_kernel(data: input_t) -> output_t:
return output


check_implementation = make_match_reference(ref_kernel, rtol=1e-2, atol=1e-2)
check_implementation = make_match_reference(ref_kernel, rtol=1e-3, atol=1e-3)
4 changes: 2 additions & 2 deletions problems/helion/gated_deltanet_chunk_fwd_h_py/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ def check_implementation(data, output):
exp_h, exp_v = expected
got_h, got_v = output

reasons_h = verbose_allclose(got_h.float(), exp_h.float(), rtol=1e-2, atol=1e-2)
reasons_v = verbose_allclose(got_v.float(), exp_v.float(), rtol=1e-2, atol=1e-2)
reasons_h = verbose_allclose(got_h.float(), exp_h.float(), rtol=1e-3, atol=1e-3)
reasons_v = verbose_allclose(got_v.float(), exp_v.float(), rtol=1e-3, atol=1e-3)

reasons = []
if reasons_h:
Expand Down
2 changes: 1 addition & 1 deletion problems/helion/gated_deltanet_chunk_fwd_o_py/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,4 @@ def ref_kernel(data: input_t) -> output_t:
return o.permute(0, 1, 3, 2, 4).reshape(B, T, H, V).to(q.dtype)


check_implementation = make_match_reference(ref_kernel, rtol=1e-2, atol=1e-2)
check_implementation = make_match_reference(ref_kernel, rtol=1e-3, atol=1e-3)
4 changes: 2 additions & 2 deletions problems/helion/gated_deltanet_recompute_w_u_py/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ def check_implementation(data, output):
exp_w, exp_u = expected
got_w, got_u = output

reasons_w = verbose_allclose(got_w, exp_w, rtol=1e-2, atol=1e-2)
reasons_u = verbose_allclose(got_u, exp_u, rtol=1e-2, atol=1e-2)
reasons_w = verbose_allclose(got_w, exp_w, rtol=1e-3, atol=1e-3)
reasons_u = verbose_allclose(got_u, exp_u, rtol=1e-3, atol=1e-3)

reasons = []
if reasons_w:
Expand Down