Calculate the year exactly based on foundation date (follow up PR #18) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kr4is
requested changes
Jul 5, 2025
Member
Kr4is
left a comment
Kr4is
left a comment
There was a problem hiding this comment.
We should delete the not needed comments 🦜
jorgeteixe
approved these changes
Jul 7, 2025
Member
Co-authored-by: Jorge Teixeira <hey@teixe.es>
migueldeoleiros
force-pushed
the
main
branch
2 times, most recently
from
16c7dc7 to
55099dd
Compare
Kr4is
approved these changes
Jul 11, 2025
Member
Kr4is
left a comment
Kr4is
left a comment
There was a problem hiding this comment.
Now it the checks are working 👍🏼
Contributor
Author
Yes, it was a simple mistake with the variable name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the calculation for how old GPUL taking the exact foundation date