-
Notifications
You must be signed in to change notification settings - Fork 99
wgsl: Add sparseMatrixRange to FPTraits API
#3183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Another stacked change, all the new code is in 744e31b |
jiangzhaoming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks
src/webgpu/shader/execution/expression/call/builtin/transpose.spec.ts
Outdated
Show resolved
Hide resolved
ben-clayton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I'm not sure if the cache should be re-generated or not based on the code changes. It might be worth checking whether you get the same diffs if we all agree on a NodeJS version to use. See #3187
| 1, | ||
| ...fullF16Range(), | ||
| ]; | ||
| const cases = (['f32', 'f16'] as const) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this and the other changes, a comment describing what cases holds (non-exhaustive fields) would be good as this made me go cross-eyed trying to figure out what it was actually doing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think something like
// Cases: [f32|f16]_[non_]const
is sufficient?
This is what jzm has included for the usage of this pattern that they wrote, but I didn't replicate consistantly.
I am currently using 20.9.0, which I believe is the newest LTS release and the same one that you pin in that PR. This PR shouldn't be changing the actual expectations significantly (There are a couple of tests that were using the wrong generator that will be changing, but most should be a no-op). It does change the code in floating_point.ts and the various .spec.ts files, so I think they should have a different hash. |
|
SGTM then, thanks! |
744e31b to
8526e2b
Compare
8526e2b to
c061342
Compare
Fixes #3174
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.