-
Notifications
You must be signed in to change notification settings - Fork 100
Add a test for the error line position #3513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm currently not able to easily get a Macbook, so I was hoping that whoever reviews this could either
|
|
Sorry I missed this. Will review next week. |
in the standalone runner it's listed under "options" which enables
It passes! Safari reports linePos=19. (The existing test case Verified the results in Chrome and Firefox too. |
kainino0x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/webgpu/api/operation/shader_module/compilation_info.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/operation/shader_module/compilation_info.spec.ts
Outdated
Show resolved
Hide resolved
|
Thank you for the contribution! |
Issue: #3489
I have tested this in Firefox Nightly (fails, as expected) and Chrome (success, as expected), but not in Safari Technology Preview. I do not have a Macbook available.
What does the "Test have be tested with compatibility mode validation enabled and behave as expected" bullet point mean?
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.