Skip to content

Conversation

@stefnotch
Copy link
Contributor

@stefnotch stefnotch commented Mar 15, 2024

Issue: #3489

I have tested this in Firefox Nightly (fails, as expected) and Chrome (success, as expected), but not in Safari Technology Preview. I do not have a Macbook available.

What does the "Test have be tested with compatibility mode validation enabled and behave as expected" bullet point mean?


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@stefnotch stefnotch marked this pull request as ready for review March 15, 2024 21:15
@stefnotch
Copy link
Contributor Author

I'm currently not able to easily get a Macbook, so I was hoping that whoever reviews this could either

  • verify that the test just passes on Safari
  • or, if not, let me know what the output is

@kainino0x
Copy link
Collaborator

Sorry I missed this. Will review next week.

@kainino0x
Copy link
Collaborator

kainino0x commented Mar 26, 2024

What does the "Test have be tested with compatibility mode validation enabled and behave as expected" bullet point mean?

in the standalone runner it's listed under "options" which enables ?compatibility=1.

  • verify that the test just passes on Safari

It passes! Safari reports linePos=19. (The existing test case
webgpu:api,operation,shader_module,compilation_info:offset_and_length:valid=false;name="unicode" does not pass, but that's unrelated.)

Verified the results in Chrome and Firefox too.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kainino0x kainino0x enabled auto-merge (squash) March 26, 2024 21:59
@kainino0x
Copy link
Collaborator

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants